-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up language strings, add openomf-translations submodule #737
base: master
Are you sure you want to change the base?
Conversation
7dfff8c
to
7fd5bbb
Compare
1909b28
to
59a33b4
Compare
This seems messy and difficult. Would it be better to just create our own language files, add only text that is used and include them to the project? Then we could drop the original language files completely. |
Should I remove the Dansk Maskinoversottelse? its derivative of ENGLISH.DAT. EDIT: removed. |
4624a25
to
99b68e8
Compare
the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still undecided about submodules, but initially okay.
Also ensures they are stored sequentially on the heap for better cache-locality.
this PR:
LangPilot
data
in a single contigous allocation, and discarding theirdescription
.Rationale for using cmake codegen instead of a straight C enum:OMF ENGLISH.DAT consumes 65,397 bytes of memory after discarding the descriptions
A cut down OpenOMF ENGLISH.LNG consumes 35,257 bytes of memory and only contains 458 strings.