Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incremental BK loading #760

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Vagabond
Copy link
Member

@Vagabond Vagabond commented Nov 7, 2024

On slow hardware, the blocking bk loading can cause the audio to stutter because it blocks the engine loop. This PR makes loading BK files incremental, so the game loop can keep ticking and loading the BK file incrementally during scene transitions.

@Vagabond Vagabond marked this pull request as ready for review November 7, 2024 21:02
@Vagabond
Copy link
Member Author

Vagabond commented Nov 7, 2024

One issue is, on scene transition without a "crossfade" it flickers a bit

Copy link
Contributor

@Nopey Nopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMF logo to main menu crossfade repeats four times
Other cross fades seem unaffected

EDIT: OpenOMF.bk to intro.bk transition can also repeat four times

2024-11-07.13-07-03.mp4

@Vagabond
Copy link
Member Author

OMF logo to main menu crossfade repeats four times Other cross fades seem unaffected

EDIT: OpenOMF.bk to intro.bk transition can also repeat four times
2024-11-07.13-07-03.mp4

This should be resolved now.

@Vagabond Vagabond force-pushed the adt/incremental-bk-loading branch from 8bc3af7 to 959ef9e Compare November 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants