game: Enable network menu in debug mode only #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nopey
requested changes
Dec 9, 2024
mrannanj
force-pushed
the
debug-network
branch
3 times, most recently
from
d026970 to
5c248de
Compare
Nopey
previously approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Unsure what the motivation for removing the launch options is (--connect and --port), but the actual code changes to accomplish this are fine.
I think leaving the network game launch options in is a good idea, as they will probably be useful when we need to check if netplay works with CI pipeline-built binaries. (and users are unlikely to discover them in error)
mrannanj
force-pushed
the
debug-network
branch
from
5c248de to
bac890d
Compare
mrannanj
force-pushed
the
debug-network
branch
from
bac890d to
f3c5aff
Compare
mrannanj
force-pushed
the
debug-network
branch
from
f3c5aff to
d2bf379
Compare
Nopey
approved these changes
Dec 9, 2024
Vagabond
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.