Strncpy #809
Closed
Strncpy #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nopey
requested changes
Dec 9, 2024
Comment on lines
+100
to
+101
| strncpy_or_truncate(chr->cutscene_text[i], trn.locales[0]->end_texts[0][i], | ||
| strlen(trn.locales[0]->end_texts[0][i])); |
There was a problem hiding this comment.
This is equivalent to calling strcpy(dst, src), and every bit as dangerous.
Do not strncpy(dst, src, strlen(src)).
There was a problem hiding this comment.
Well, also the omf_calloc is just on the previous line, but let's try strdup then.
| @@ -62,8 +62,6 @@ int sd_vga_image_decode(sd_rgba_image *dst, const sd_vga_image *src, const vga_p | |||
| } | |||
|
|
|||
| int sd_vga_image_from_png(sd_vga_image *img, const char *filename) { | |||
There was a problem hiding this comment.
Is there a benefit to these sd_vga_image_from_png changes?
Also: i believe this is now leaking memory, as info_ptr is not consistently passed to png_destroy_read_struct for freeing.
| @@ -181,7 +182,7 @@ int sd_chr_load(sd_chr_file *chr, const char *filename) { | |||
| for(int m = 0; m < 10; m++) { | |||
| if(trn_loaded && trn.enemies[i]->quotes[m]) { | |||
| chr->enemies[i]->pilot.quotes[m] = omf_calloc(1, strlen(trn.enemies[i]->quotes[m]) + 1); | |||
| strncpy(chr->enemies[i]->pilot.quotes[m], trn.enemies[i]->quotes[m], strlen(trn.enemies[i]->quotes[m])); | |||
| strncpy_or_truncate(chr->enemies[i]->pilot.quotes[m], trn.enemies[i]->quotes[m], strlen(trn.enemies[i]->quotes[m])); | |||
There was a problem hiding this comment.
Ditto.
This is equivalent to calling strcpy(dst, src), and every bit as dangerous.
Do not strncpy(dst, src, strlen(src)).
|
didn't notice this was a draft before reviewing it, oops? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.