Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement relative option for lighten/darken manipulation #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: implement relative option for lighten/darken manipulation #91

wants to merge 1 commit into from

Conversation

EricRovell
Copy link
Contributor

#90 issue has a valid point: the relative lightness manipulation has a lot of sense.

At first I thought it should be the default behavior, still, as it may be a breaking change, I implemented the feature as an optional relative: Boolean parameter.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2022

Codecov Report

Merging #91 (2bf9b27) into master (aafcf7c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines          622       623    +1     
  Branches       115       142   +27     
=========================================
+ Hits           622       623    +1     
Impacted Files Coverage Δ
src/colord.ts 100.00% <100.00%> (ø)
src/manipulate/lighten.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafcf7c...2bf9b27. Read the comment docs.

@Nantris Nantris mentioned this pull request Aug 5, 2022
@EricRovell EricRovell closed this by deleting the head repository Oct 2, 2022
@EricRovell EricRovell reopened this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants