-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade omise-node api to v2019 #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the readme. 2 minor comments.
Some examples of library usage are also listed below:
Rewrite as:
Some examples of library usage are also listed as follows:
--
Maintenance mode means bug fixes and security patches only**.**
The full stop is missing in the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the Readme.
Description
More information (if any)
Documentation (if any)
Related links:
Decision(s)
In the context of < use case / user story >, facing < concern > we decided for < option > to achieve < quality / goal >, accepting < downside >.
***NOTE: If the change introduces a new feature flag, please mention: ***
Business impact (if any)
Pre- or post-deployment steps (if any)
Rollback procedure