Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade omise-node api to v2019 #220

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Upgrade omise-node api to v2019 #220

merged 15 commits into from
Sep 17, 2024

Conversation

gaurab13
Copy link
Contributor

@gaurab13 gaurab13 commented Aug 29, 2024

Description

  • Upgrade library to support API version 2019-05-29

More information (if any)

  • Added setup to run the typescript examples
  • Refactored example scripts
  • Updated resource fields according to api v 2019-05-29

Documentation (if any)

Related links:

  • Issue ID:

Decision(s)

In the context of < use case / user story >, facing < concern > we decided for < option > to achieve < quality / goal >, accepting < downside >.

***NOTE: If the change introduces a new feature flag, please mention: ***

  • When / Conditions to remove feature flag
  • Please add label "FeatureFlag" to feature flag removal story

Business impact (if any)

Pre- or post-deployment steps (if any)

Rollback procedure

@gaurab13 gaurab13 marked this pull request as ready for review September 2, 2024 11:04
@gaurab13 gaurab13 requested review from aashishgurung and AnasNaouchi and removed request for aashishgurung September 3, 2024 03:07
package.json Outdated Show resolved Hide resolved
@gaurab13 gaurab13 changed the title Upgrade api v2019 Upgrade omise-node api to v2019 Sep 13, 2024
Copy link
Contributor

@muthuswamyopn muthuswamyopn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the readme. 2 minor comments.

Some examples of library usage are also listed below:

Rewrite as:

Some examples of library usage are also listed as follows:

--

Maintenance mode means bug fixes and security patches only**.**

The full stop is missing in the text.

Copy link
Contributor

@muthuswamyopn muthuswamyopn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme is fine.

Copy link
Contributor

@muthuswamyopn muthuswamyopn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Readme.

@gaurab13 gaurab13 merged commit a223a90 into master Sep 17, 2024
9 checks passed
@gaurab13 gaurab13 deleted the upgrade_api_v2019 branch September 17, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants