Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to omni/tokenbridge-contracts#365
Follow instructions in README file to test the plugin.
The plugin adds the following definitions to be used by the existing Exchange plugin:
Assets:
Gateway:
Pair:
Project structure
tokenbridge-plugin
plugin definitionlocal-wallet
Burner wallet using the plugin with a Native - ERC20 bridge deployed in Sokol - Kovan on top of AMB.basic-wallet
Burner wallet using the plugin with the existing WETC Bridge in mainnet and Classic.I tested the plugin in Sokol - Kovan and also with the WETC Bridge in mainnet and Classic and it worked correctly.
Here are some notes from my testing related more to the Burner Wallet user experience rather than the plugin itself:
exchange
plugin.metamask-plugin
.exchange
plugin, I guess a possible improvement to propose would be to allow Exchange Pairs to set a feedback message after the execution so the user can be informed on the delay due to the bridge operations.