Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-4481] Fixed the installation of the agent's addons on its virtual environment #16

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Aug 14, 2024

An issue was identified when the addons included extra parameters for pip, for instance: "some-plugin==0.4.1 -i <value> --extra-index-url <value>". The logs on the charm show:

2024-08-14 20:53:20 DEBUG unit.jobbergate-agent/2.juju-log server.go:325 Emitting Juju event config_changed.
2024-08-14 20:53:20 DEBUG unit.jobbergate-agent/2.juju-log server.go:325 ## Installing jobbergate-addons: ['/srv/jobbergate-agent-venv/bin/pip', 'install', '-U', 'some-plugin==0.4.1 -i <value> --extra-index-url <value>']
2024-08-14 20:53:21 WARNING unit.jobbergate-agent/2.config-changed logger.go:60 ERROR: Invalid requirement: 'some-plugin==0.4.1 -i <value> --extra-index-url <value>'
2024-08-14 20:53:21 WARNING unit.jobbergate-agent/2.config-changed logger.go:60 Hint: It looks like a path. File 'some-plugin==0.4.1 -i <value> --extra-index-url <value>' does not exist.

After the changes on the PR we see:

2024-08-14 21:12:36 DEBUG unit.jobbergate-agent/2.juju-log server.go:325 Emitting Juju event config_changed.
2024-08-14 21:12:36 DEBUG unit.jobbergate-agent/2.juju-log server.go:325 ## Installing jobbergate-addons: ['/srv/jobbergate-agent-venv/bin/pip', 'install', '-U', 'some-plugin==0.4.1', '-i', '<value>', '--extra-index-url', '<value>']
2024-08-14 21:12:36 DEBUG unit.jobbergate-agent/2.config-changed logger.go:60 Looking in indexes: <value>, <value>
2024-08-14 21:12:36 DEBUG unit.jobbergate-agent/2.config-changed logger.go:60 Collecting some-plugin==0.4.1

@fschuch fschuch force-pushed the fschuch/ASP-4481--fix-install-jobbergate-addon branch 2 times, most recently from cf4c071 to c86a849 Compare August 14, 2024 21:35
@fschuch fschuch force-pushed the fschuch/ASP-4481--fix-install-jobbergate-addon branch from c86a849 to 9947d10 Compare August 14, 2024 21:37
@fschuch fschuch requested a review from jaimesouza August 14, 2024 21:43
@fschuch fschuch merged commit 964e5f5 into main Aug 15, 2024
1 check passed
@fschuch fschuch deleted the fschuch/ASP-4481--fix-install-jobbergate-addon branch August 15, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants