[ASP-3985] Add extra params create-job-script #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusktreader
requested changes
Oct 18, 2023
fschuch
requested changes
Oct 18, 2023
julianaklulo
force-pushed
the
ASP-3985--extra-params-create-job-script
branch
from
80f4541 to
3895de3
Compare
fschuch
reviewed
Oct 18, 2023
fschuch
reviewed
Oct 18, 2023
fschuch
reviewed
Oct 19, 2023
fschuch
reviewed
Oct 19, 2023
julianaklulo
force-pushed
the
ASP-3985--extra-params-create-job-script
branch
from
487d194 to
dce78f2
Compare
fschuch
approved these changes
Oct 19, 2023
dusktreader
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the command
create-job-script(render) to include extra params for submission mode.The parameters can be specified by the user when invoking the command.
When running on fast mode, if they're not specified, the parameters default to:
--cluster-name: cluster where the CLI is running--execution-directory: current working directory--download:TrueOn non fast mode, the user is prompted with two questions:
"
Submit the job immediately?" and "Download job script file?"Why
To enable the submission mode on create-job-script command.
Task: https://jira.scania.com/browse/ASP-3985Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.