Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-4069] Naming convention for job files #401

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Oct 31, 2023

What

Make it behave like in legacy jobbergate.

Why

The modification and interpretation of .job-files is a daily part of the job for simulation engineers. For some physical problems adjustment of the .job-file is an iterative process, for all physical problems it's part of the bug finding if something goes wrong in the analysis. Therefore a lot of time can be saved by keeping track of what .job-file corresponds to what SLURM job.

Task: https://jira.scania.com/browse/ASP-4069


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

@fschuch fschuch force-pushed the ASP-4069-name-convention-for-job-files branch from 28ec8a7 to abcedcb Compare October 31, 2023 15:03
@fschuch fschuch requested a review from dusktreader October 31, 2023 15:08
jobbergate-cli/CHANGELOG.md Outdated Show resolved Hide resolved
jobbergate-cli/jobbergate_cli/subapps/job_scripts/tools.py Outdated Show resolved Hide resolved
@fschuch fschuch force-pushed the ASP-4069-name-convention-for-job-files branch 2 times, most recently from 6168233 to 72caac9 Compare November 8, 2023 18:49
@fschuch fschuch merged commit ca9c8d9 into main Nov 8, 2023
4 checks passed
@fschuch fschuch deleted the ASP-4069-name-convention-for-job-files branch November 8, 2023 19:25
@omnivector-qa
Copy link
Contributor

The backport to release/4.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/4.1 release/4.1
# Navigate to the new working tree
cd .worktrees/backport-release/4.1
# Create a new branch
git switch --create backport-401-to-release/4.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ca9c8d977fd03211e69e4e69abaf3b3ae68540f6
# Push it to GitHub
git push --set-upstream origin backport-401-to-release/4.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/4.1

Then, create a pull request where the base branch is release/4.1 and the compare/head branch is backport-401-to-release/4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants