Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-4245] Update agent download logic file #419

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

julianaklulo
Copy link
Contributor

What

Add the env var DOWNLOAD_JOB_SCRIPT to control whether the agent should download the job script file.
If it's set to True, the behaviour is exactly as before.
If it's set to False, the submission will be rejected if there are supporting files. If there aren't, the job script will be passed to the slurmrestd API as the payload and won't be downloaded to the submit dir.

Why

The submission was failing when the agent didn't have permission to write to the submit dir.

Task: https://jira.scania.com/browse/ASP-4245


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link
Member

@matheushent matheushent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jobbergate-agent/jobbergate_agent/jobbergate/submit.py Outdated Show resolved Hide resolved
jobbergate-agent/jobbergate_agent/jobbergate/submit.py Outdated Show resolved Hide resolved
jobbergate-agent/jobbergate_agent/jobbergate/submit.py Outdated Show resolved Hide resolved
jobbergate-agent/jobbergate_agent/settings.py Outdated Show resolved Hide resolved
@julianaklulo julianaklulo requested a review from fschuch November 28, 2023 03:25
@julianaklulo julianaklulo merged commit 38d6e09 into main Nov 28, 2023
4 checks passed
@julianaklulo julianaklulo deleted the juliana/ASP-4245--agent-download-file-logic branch November 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants