-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP-4245] Update agent download logic file #419
Merged
julianaklulo
merged 9 commits into
main
from
juliana/ASP-4245--agent-download-file-logic
Nov 28, 2023
Merged
[ASP-4245] Update agent download logic file #419
julianaklulo
merged 9 commits into
main
from
juliana/ASP-4245--agent-download-file-logic
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheushent
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fschuch
requested changes
Nov 23, 2023
fschuch
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the env var
DOWNLOAD_JOB_SCRIPT
to control whether the agent should download the job script file.If it's set to
True
, the behaviour is exactly as before.If it's set to
False
, the submission will be rejected if there are supporting files. If there aren't, the job script will be passed to theslurmrestd
API as the payload and won't be downloaded to the submit dir.Why
The submission was failing when the agent didn't have permission to write to the submit dir.
Task
: https://jira.scania.com/browse/ASP-4245Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.