-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP-3966] Implement pagination #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianaklulo
force-pushed
the
juliana/ASP-3966--implement-pagination
branch
from
December 4, 2023 19:46
f037749
to
e69febf
Compare
fschuch
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I left a few comments for you.
julianaklulo
force-pushed
the
juliana/ASP-3966--implement-pagination
branch
from
December 7, 2023 23:25
3f32e31
to
fabca65
Compare
fschuch
reviewed
Dec 8, 2023
Could we change the three listing commands to sort descending by |
fschuch
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement pagination for
list_all
commands for each subapp:job-script-templates
,job-scripts
andjob-submissions
.Why
The users couldn't see all the results because only the first page of results was being rendered.
Task
: https://jira.scania.com/browse/ASP-3966Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.