Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP-3966] Implement pagination #430

Merged
merged 24 commits into from
Dec 8, 2023

Conversation

julianaklulo
Copy link
Contributor

What

Implement pagination for list_all commands for each subapp: job-script-templates, job-scripts and job-submissions.

Why

The users couldn't see all the results because only the first page of results was being rendered.

Task: https://jira.scania.com/browse/ASP-3966


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

@julianaklulo julianaklulo force-pushed the juliana/ASP-3966--implement-pagination branch from f037749 to e69febf Compare December 4, 2023 19:46
Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I left a few comments for you.

jobbergate-cli/jobbergate_cli/render.py Outdated Show resolved Hide resolved
jobbergate-cli/jobbergate_cli/render.py Outdated Show resolved Hide resolved
jobbergate-cli/jobbergate_cli/subapps/pagination.py Outdated Show resolved Hide resolved
jobbergate-cli/poetry.lock Outdated Show resolved Hide resolved
@julianaklulo julianaklulo force-pushed the juliana/ASP-3966--implement-pagination branch from 3f32e31 to fabca65 Compare December 7, 2023 23:25
@julianaklulo julianaklulo requested a review from fschuch December 8, 2023 00:01
@fschuch
Copy link
Member

fschuch commented Dec 8, 2023

Could we change the three listing commands to sort descending by id by default? Now with pagination, the unsorted by default is bugging me 😅. I think it makes more sense to show more recent first.

@julianaklulo julianaklulo merged commit f366dc1 into main Dec 8, 2023
@julianaklulo julianaklulo deleted the juliana/ASP-3966--implement-pagination branch December 8, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants