Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENG-2159 Expanded permission sets #523

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

dusktreader
Copy link
Member

Remapped permissions to expand from a view/edit paradigm to individual permissions for create/read/update/delete.

Updated the API with the permission sets.
Updated jobbergate-composed to use the new permission sets.


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (2dcc5cc) to head (bc2c200).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   91.99%   92.01%   +0.01%     
==========================================
  Files          82       82              
  Lines        4398     4406       +8     
==========================================
+ Hits         4046     4054       +8     
  Misses        352      352              
Flag Coverage Δ
agent 93.51% <ø> (ø)
api 95.02% <ø> (+0.02%) ⬆️
cli 88.25% <ø> (ø)
core 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I left a couple of comments for you.

jobbergate-composed/etc/jobbergate-local.json Outdated Show resolved Hide resolved
@dusktreader dusktreader force-pushed the tucker/PENG-2159--expand-permission-sets branch from 16b007e to 87ff2d0 Compare April 15, 2024 16:26
Remapped permissions to expand from a view/edit paradigm to individual
permissions for create/read/update/delete.

Updated the API with the permission sets.
Updated jobbergate-composed to use the new permission sets.
@dusktreader dusktreader force-pushed the tucker/PENG-2159--expand-permission-sets branch from 15a33e5 to bc2c200 Compare April 23, 2024 15:28
@dusktreader dusktreader merged commit 6e4ff67 into main Apr 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants