Revised setup for jobbergate-agent in jobbergate-composed #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusktreader
force-pushed
the
revise-composed-setup-for-jobbergate-agent
branch
from
8adf65d to
c248d4d
Compare
This change moves jobbergate-agent into a stand-alone slurmd node instead of embedding it in the slurmctld node. This will more closely mimic what we do in production where agents are installed on login nodes.
dusktreader
force-pushed
the
revise-composed-setup-for-jobbergate-agent
branch
from
c248d4d to
073ded9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 91.93% 91.92% -0.01%
==========================================
Files 80 80
Lines 4279 4274 -5
==========================================
- Hits 3934 3929 -5
Misses 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fschuch
approved these changes
Apr 8, 2024
dusktreader
force-pushed
the
revise-composed-setup-for-jobbergate-agent
branch
from
5d3ea9b to
073ded9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves jobbergate-agent into a stand-alone slurmd node instead of embedding it in the slurmctld node. This will more closely mimic what we do in production where agents are installed on login nodes.
Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.