Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENG-2248 Replaced deprecated pkg_resources dependency #554

Merged

Conversation

dusktreader
Copy link
Member

What

Replaced deprecated pkg_resources.get_distribution with importlib.metadata.version.

Why

To preserve compatibility with Python 3.12.

Task: https://app.clickup.com/t/18022949/PENG-2248


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (5488fae) to head (1c77ea3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files          82       82           
  Lines        4431     4431           
=======================================
  Hits         4086     4086           
  Misses        345      345           
Flag Coverage Δ
agent 93.51% <ø> (ø)
api 95.50% <ø> (ø)
cli 88.25% <ø> (ø)
core 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jamesbeedy jamesbeedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dusktreader dusktreader merged commit a8b3915 into main May 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants