PENG-2230 remove the audience setting from the API project #571
+4
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 92.21% 92.21% -0.01%
==========================================
Files 83 83
Lines 4459 4457 -2
==========================================
- Hits 4112 4110 -2
Misses 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matheushent
force-pushed
the
matheushent/PENG-2230--remove-aud--api
branch
from
bb5ef73 to
9b277ab
Compare
matheushent
force-pushed
the
matheushent/PENG-2230--remove-aud--api
branch
from
9b277ab to
7bcdd3c
Compare
fschuch
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR only removes the audience setting from the settings class of the API.
Why
This is a deprecated feature we used some time ago and it makes no sense anymore to keep it.
Task: https://sharing.clickup.com/t/h/c/18022949/PENG-2230/O40JANAF6KCBE9RPeer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.