Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PENG-2230 remove the audience setting from the API project #571

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

matheushent
Copy link
Member

What

This PR only removes the audience setting from the settings class of the API.

Why

This is a deprecated feature we used some time ago and it makes no sense anymore to keep it.

Task: https://sharing.clickup.com/t/h/c/18022949/PENG-2230/O40JANAF6KCBE9R


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (5b00121) to head (7bcdd3c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   92.21%   92.21%   -0.01%     
==========================================
  Files          83       83              
  Lines        4459     4457       -2     
==========================================
- Hits         4112     4110       -2     
  Misses        347      347              
Flag Coverage Δ
agent 93.41% <ø> (ø)
api 95.27% <ø> (-0.01%) ⬇️
cli 88.48% <ø> (ø)
core 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matheushent matheushent force-pushed the matheushent/PENG-2230--remove-aud--api branch from bb5ef73 to 9b277ab Compare July 2, 2024 16:54

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@matheushent matheushent force-pushed the matheushent/PENG-2230--remove-aud--api branch from 9b277ab to 7bcdd3c Compare July 2, 2024 17:11
@matheushent matheushent requested a review from fschuch July 3, 2024 14:15
@matheushent matheushent merged commit d1fdaa7 into main Jul 19, 2024
12 checks passed
@matheushent matheushent deleted the matheushent/PENG-2230--remove-aud--api branch July 19, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants