fix(api): Drop StreamingResponse after issues on latest FastAPI #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschuch
force-pushed
the
fschuch/fix-api--routes-to-get-files
branch
2 times, most recently
from
1522f59 to
60359ad
Compare
fschuch
force-pushed
the
fschuch/fix-api--routes-to-get-files
branch
from
60359ad to
b806865
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #582 +/- ##
==========================================
- Coverage 92.22% 92.21% -0.01%
==========================================
Files 83 83
Lines 4461 4459 -2
==========================================
- Hits 4114 4112 -2
Misses 347 347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dusktreader
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Some interaction between the s3 object from aiboto3 and the StreamingResponse from FastAPI resulted in intermittent errors when retrieving files from get endpoints. The issue was persistent for large files.
Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.