PENG-2456 enable job metric collection in the API #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/PENG-2455--job-metric-collection #665 +/- ##
============================================================================
+ Coverage 92.57% 92.71% +0.14%
============================================================================
Files 85 86 +1
Lines 4483 4683 +200
============================================================================
+ Hits 4150 4342 +192
- Misses 333 341 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…vailable by the API
matheushent
force-pushed
the
matheushent/PENG-2456--job-metric-collection--api
branch
from
600b2db to
ff96f56
Compare
dusktreader
requested changes
Dec 12, 2024
jobbergate-api/alembic/versions/20241128_162020--99c3877d0f10_create_job_metric_table.py
Show resolved
Hide resolved
…ons/helpers.py based on the PR review
… instead of 422 when *start_time* is greater than *end_time*
…_agent_metrics_upload* endpoint
… endpoint to a dedicated function in the helpers module
…icSchema* model to use generator expressions instead of map and filter
matheushent
force-pushed
the
matheushent/PENG-2456--job-metric-collection--api
branch
from
6a48597 to
925ae78
Compare
…e *validate_job_metric_upload_input* function
dusktreader
approved these changes
Dec 13, 2024
matheushent
merged commit cb06f8c
into
feature/PENG-2455--job-metric-collection
13 checks passed
matheushent
deleted the
matheushent/PENG-2456--job-metric-collection--api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements all the necessary logic for receiving job metrics from the agent and making them available by the API. For any specific detail, check the task linked.
Why
Improve the experience regarding the job submissions.
Task: https://sharing.clickup.com/t/h/c/18022949/PENG-2456/43YCG8RCBBQJELQPeer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.