Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): run rendering process in a Sandbox Environment #671

Merged

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Dec 16, 2024

Cherry-pick 4a19d1c (PR #667) to the main branch.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (75b741a) to head (a9807bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
+ Coverage   92.57%   92.58%   +0.01%     
==========================================
  Files          85       85              
  Lines        4483     4490       +7     
==========================================
+ Hits         4150     4157       +7     
  Misses        333      333              
Flag Coverage Δ
agent 92.80% <ø> (ø)
api 95.33% <ø> (+0.01%) ⬆️
cli 88.62% <ø> (+0.02%) ⬆️
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@julianaklulo julianaklulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, but otherwise looks good to me

jobbergate-api/CHANGELOG.md Show resolved Hide resolved
jobbergate-api/tests/apps/test_services.py Outdated Show resolved Hide resolved
@fschuch fschuch merged commit e6827ea into main Dec 17, 2024
13 checks passed
@fschuch fschuch deleted the cherry-pick/run-rendering-process-in-a-Sandbox-Environment branch December 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants