fix(agent): PENG-2457 fix the *epoch* param when querying InfluxDB for metrics. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r metrics. This commit modifies the *epoch* param of the *.query* method in the function *fetch_influx_data* when querying InfluxDB for metrics. The previous argument, i.e. *us*, was generating errors in the API when converting the timestamp to datetime objects necessary for SQLAlchemy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/PENG-2455--job-metric-collection #678 +/- ##
===========================================================================
Coverage ? 92.83%
===========================================================================
Files ? 88
Lines ? 4842
Branches ? 0
===========================================================================
Hits ? 4495
Misses ? 347
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dusktreader
approved these changes
Dec 19, 2024
fschuch
approved these changes
Dec 19, 2024
matheushent
merged commit 1b3f28e
into
feature/PENG-2455--job-metric-collection
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the epoch param of the
.querymethod in the function fetch_influx_data when querying InfluxDB for metrics. The previous argument, i.e. us, was generating errors in the API when converting the timestamp todatetimeobjects necessary for SQLAlchemy.Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.