cherry-pick: PENG-2678 Fixed issue with handle_errors_async #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/5.4 #694 +/- ##
===============================================
+ Coverage 92.58% 92.65% +0.06%
===============================================
Files 85 85
Lines 4493 4466 -27
===============================================
- Hits 4160 4138 -22
+ Misses 333 328 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dusktreader
requested changes
Jan 30, 2025
|
Please remember to add the |
The implementation of `handle_errors_async()` that was embedded in the `jobbergate-agent` was not compatible with a recent update to `py-buzz` version `4.1`. This change removes the embedded implementation in favor of using the upstream implementation of the same that is now a part of `py-buzz` version `5.0`. Original Commit: 0948b69
fschuch
force-pushed
the
cherry-pick/PENG-2678--fix-agent-issue-with-handle_errors_async
branch
from
f94adda to
1a1c521
Compare
Good catch, I got it now. |
dusktreader
approved these changes
Jan 31, 2025
fschuch
deleted the
cherry-pick/PENG-2678--fix-agent-issue-with-handle_errors_async
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
handle_errors_async()that was embedded in thejobbergate-agentwas not compatible with a recent update topy-buzzversion
4.1.This change removes the embedded implementation in favor of using the
upstream implementation of the same that is now a part of
py-buzzversion
5.0.Original Commit: 0948b69