fix(jobbergate-agent-snap): Fixed problem config hook #695
+25
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `snap set` command is used in quick succession (such as when invoked through the `cloud-init.yaml` of the democluster, the command can fail. This is happening because the snap attempts to restart rapidly when it fails to start. The start will fail because the jobbergate-agent is missing required config. When the configure hook directs the snap to restart, it may happen while the snap is in a restart cycle. Snap will detect that the restart request happened too soon after a failed restart attempt and the command will fail. Setting the snap as disabled while the configure hook is running seems to fix this issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 85 85
Lines 4466 4466
=======================================
Hits 4138 4138
Misses 328 328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
snap setcommand is used in quick succession (such as when invoked through thecloud-init.yamlof the democluster, the command can fail. This is happening because the snap attempts to restart rapidly when it fails to start. The start will fail because the jobbergate-agent is missing required config.When the configure hook directs the snap to restart, it may happen while the snap is in a restart cycle. Snap will detect that the restart request happened too soon after a failed restart attempt and the command will fail.
Setting the snap as disabled while the configure hook is running seems to fix this issue.