-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a account-archived page on web for archived users to export data #4355
Open
sywhb
wants to merge
1
commit into
main
Choose a base branch
from
feature/account-archived
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { useState } from 'react' | ||
import { showErrorToast, showSuccessToast } from '../../lib/toastHelpers' | ||
import { Button } from '../elements/Button' | ||
|
||
export function ExportDataButton(): JSX.Element { | ||
const [disabledState, setDisabledState] = useState<boolean>(false) | ||
|
||
const handleExportClick = async () => { | ||
setDisabledState(true) | ||
|
||
try { | ||
// Make a GET request to the /export endpoint | ||
const response = await fetch('/api/export', { | ||
method: 'GET', | ||
headers: { | ||
'Content-Type': 'application/json', | ||
}, | ||
}) | ||
|
||
if (!response.ok) { | ||
throw new Error('Failed to fetch export data') | ||
} | ||
} catch (error) { | ||
console.error('Error exporting data:', error) | ||
showErrorToast('Failed to export data') | ||
|
||
setDisabledState(false) | ||
return | ||
} | ||
|
||
showSuccessToast( | ||
'Started exporting data. You will receive an email shortly.' | ||
) | ||
} | ||
|
||
return ( | ||
<Button | ||
type="submit" | ||
style={disabledState ? 'ctaGray' : 'ctaOmnivoreYellow'} | ||
css={{ | ||
padding: '10px 50px', | ||
}} | ||
disabled={disabledState} | ||
onClick={() => { | ||
handleExportClick() | ||
}} | ||
> | ||
Export My Data | ||
</Button> | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { VStack } from '../components/elements/LayoutPrimitives' | ||
import { ExportDataButton } from '../components/templates/ExportDataForm' | ||
|
||
export default function AccountArchivedPage(): JSX.Element { | ||
return ( | ||
<VStack alignment="center" distribution="center"> | ||
<h1>Your account has been archived</h1> | ||
<p> | ||
Your account has been archived. If you would like to reactivate your | ||
account, please contact support. | ||
</p> | ||
|
||
<ExportDataButton /> | ||
</VStack> | ||
) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if they click this multiple times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two cases:
200
. Probably we should return202
instead2a. if not exceed, create a new export task
2b. if exceed, failed and return
400
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
Is there any way in API to get the status of the export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can reuse the same export API by providing different status code like
200
or204
. Alternatively there is a/task/{{id}}
API which could be used to query the status of a taskThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think probably I will just reuse the
/export
API and use the status code and state in the response