Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Past and Future fixes #513

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Some Past and Future fixes #513

merged 4 commits into from
Oct 12, 2024

Conversation

deusabianca
Copy link
Contributor

@deusabianca deusabianca commented Jul 15, 2024

Fix Harbinger Descent's and Encased Fossil's ID, remove redundant New Age spells from PAF's cards.ts

@Torgen
Copy link
Contributor

Torgen commented Jul 16, 2024

Inscrutable Artifact's id also has a space.

@on3iro
Copy link
Owner

on3iro commented Jul 17, 2024

@deusabianca Thanks for the fixes. Could you please also make the adjustment @Torgen suggested? Then this should be good to go :)

@deusabianca
Copy link
Contributor Author

Done.
What I would watch for this to fix: Resonant Pearl was not appearing at all for New Age, and Harbinger Descent appearing twice for Past and Future. If it's not fixed after this I'm not sure what is causing it.
image image

@on3iro
Copy link
Owner

on3iro commented Jul 18, 2024

Done. What I would watch for this to fix: Resonant Pearl was not appearing at all for New Age, and Harbinger Descent appearing twice for Past and Future. If it's not fixed after this I'm not sure what is causing it. image image

Alright, thanks for the headsup. I currently don't have time to check this out, but will soon.

@deusabianca
Copy link
Contributor Author

Hi, any update?

@on3iro
Copy link
Owner

on3iro commented Jul 25, 2024

Hi, any update?

Sorry not yet. Pretty busy right now.

@on3iro
Copy link
Owner

on3iro commented Jul 27, 2024

Finally got around to test this. Thanks @deusabianca :)

@on3iro
Copy link
Owner

on3iro commented Jul 27, 2024

I'll have to fix e2e-tests - don't have time for that right now. So this'll have to wait a big longer (unless you can fix them yourself @deusabianca )

@on3iro
Copy link
Owner

on3iro commented Aug 19, 2024

Hey @deusabianca I haven't forgotten about his, I just didn't find time, yet. Just so you know :)

@deusabianca
Copy link
Contributor Author

Hello, I tried to make sense of how to fix it but I have no idea honestly. Anyway I hope you're doing well.

BTW I would be more than willing to add the data for the new cards from wave 8 when that comes. But would need help for however to integrate it.

@on3iro
Copy link
Owner

on3iro commented Oct 12, 2024

Hello, I tried to make sense of how to fix it but I have no idea honestly. Anyway I hope you're doing well.

BTW I would be more than willing to add the data for the new cards from wave 8 when that comes. But would need help for however to integrate it.

hey @deusabianca , yeah - sorry that it's taking me so long to fix this. Unfortunately I don't have any time to dedicate to this right now. It will definitely be a while until I'll be able to look into this.
Fixing these tests is a bit of a pain.

I think I'll remove that they are mandatory for merging for now, so I can make a release with your fixes. In the end it's just a content change anyway, so it shouldn't do any damage to the app itself.

Regarding wave 8: you are more than welcome to provide content. Thanks a lot for your effort. It might make sense to create an issue for this so we can assign you. That way other people know, that someone is already working on this.
Would you please be so kind and do that?
Thanks :)

@on3iro on3iro merged commit c795146 into on3iro:main Oct 12, 2024
2 of 3 checks passed
@deusabianca
Copy link
Contributor Author

Hey @on3iro, looks like this did break the supply randomizer. This should probably be reverted for now.

And sure I can create the issue regarding wave 8.

@on3iro
Copy link
Owner

on3iro commented Oct 13, 2024

Hey @on3iro, looks like this did break the supply randomizer. This should probably be reverted for now.

And sure I can create the issue regarding wave 8.

oh, thanks for letting me know - ill revert asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants