Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make develop cost a first class field in ICard #514

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

Torgen
Copy link
Contributor

@Torgen Torgen commented Jul 18, 2024

instead of putting it in the effect.

instead of putting it in the effect.
@on3iro
Copy link
Owner

on3iro commented Jul 18, 2024

@Torgen Could you please provide a bit more context on why this is necessary/useful? I don't yet understand what we would gain from this change.

@Torgen
Copy link
Contributor Author

Torgen commented Jul 18, 2024

On the card, the develop cost is at the top next to the regular cost, so it makes sense for it to be in a similar place in the app. If I'm reading the supply cards to someone out of the app, I would tell them the develop cost at the same time as the regular cost, not after the rest of the effect.

@on3iro
Copy link
Owner

on3iro commented Jul 18, 2024

On the card, the develop cost is at the top next to the regular cost, so it makes sense for it to be in a similar place in the app. If I'm reading the supply cards to someone out of the app, I would tell them the develop cost at the same time as the regular cost, not after the rest of the effect.

That makes sense - thanks for the explanation

@on3iro on3iro merged commit 40286ed into on3iro:main Jul 18, 2024
3 checks passed
@Torgen Torgen deleted the develop branch July 19, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants