Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the source when handling events #671

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • fix

What this PR does:

  • Restrict event messages to be delivered only to the source on the current page.
    The trusted domains that can then execute Adena commands are managed by an in-service feature in Adena.

  • Check the event source address in the event message listener function.

  • When sending an event message, specify the target origin.

@jinoosss jinoosss requested a review from a team as a code owner January 27, 2025 07:07
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinoosss jinoosss merged commit c987a23 into main Jan 30, 2025
2 checks passed
@jinoosss jinoosss deleted the ADN-660-hal-001-medium-event-listener-accepts-messages-from-any-origin branch January 30, 2025 07:41
This was referenced Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants