Skip to content

Commit

Permalink
Refine the warning msgs
Browse files Browse the repository at this point in the history
Signed-off-by: chenwei.sun <[email protected]>
  • Loading branch information
tomflinda committed Feb 10, 2025
1 parent e356f58 commit 3fd104a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions clang/lib/DPCT/RulesAsm/AsmMigration.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2725,9 +2725,10 @@ class SYCLGen : public SYCLGenBase {
.str();

report(Diagnostics::FUNC_CALL_REMOVED, true, CommonStr,
"there is no equivalent "
"functionality in "
"SYCL side. You may need to adjust the code.");
"SYCL currently has a functionality gap for asynchronous copy "
"operations. Synchronous copy operations are used on the SYCL "
"side and may cause performance issues. You may need to adjust "
"the code.");
return SYCLGenSuccess();
}
return SYCLGenError();
Expand Down
6 changes: 3 additions & 3 deletions clang/test/dpct/asm/cp.cu
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// CHECK:inline void cp_async_commit_group() {
// CHECK-NEXT: /*
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.commit_group;" was removed because there is no equivalent functionality in SYCL side. You may need to adjust the code.
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.commit_group;" was removed because SYCL currently has a functionality gap for asynchronous copy operations. Synchronous copy operations are used on the SYCL side and may cause performance issues. You may need to adjust the code.
// CHECK-NEXT: */
// CHECK-EMPTY:
// CHECK-NEXT:}
Expand All @@ -21,7 +21,7 @@ asm volatile("cp.async.commit_group;" ::);

// CHECK:inline void cp_async_wait_group() {
// CHECK-NEXT: /*
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.wait_group 0;" was removed because there is no equivalent functionality in SYCL side. You may need to adjust the code.
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.wait_group 0;" was removed because SYCL currently has a functionality gap for asynchronous copy operations. Synchronous copy operations are used on the SYCL side and may cause performance issues. You may need to adjust the code.
// CHECK-NEXT: */
// CHECK-EMPTY:
// CHECK-NEXT:}
Expand All @@ -31,7 +31,7 @@ asm volatile("cp.async.wait_group 0;");

// CHECK:inline void cp_async_wait_all() {
// CHECK-NEXT: /*
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.wait_all;" was removed because there is no equivalent functionality in SYCL side. You may need to adjust the code.
// CHECK-NEXT: DPCT1026:{{[0-9]+}}: The call to "cp.async.wait_all;" was removed because SYCL currently has a functionality gap for asynchronous copy operations. Synchronous copy operations are used on the SYCL side and may cause performance issues. You may need to adjust the code.
// CHECK-NEXT: */
// CHECK-EMPTY:
// CHECK-NEXT:}
Expand Down

0 comments on commit 3fd104a

Please sign in to comment.