Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x64: pool: Accuracy issue in benchnn pooling test #2711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jstachowintel
Copy link

Opening one more time this PR. The previous one was here.

It is similar use case as #2627. The problem is with huge input sizes, so I decided disable src_size <= INT_MAX for jit:avx512_core implementation.

@github-actions github-actions bot added the platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 label Feb 17, 2025
@jstachowintel
Copy link
Author

jstachowintel commented Feb 17, 2025

@rjoursler
Unfortunately, I closed the previous PR, so I opened another one.
Practically I agree that a user can pass an overflowed value for any input attribute, so I added changed has_large_buffers, where I think that we don't need to check wei, dst, and bia memory descs in the pooling case. Changing variable types in struct on dim_t would be inaccurate because we would never use these extra 4 bytes.

@jstachowintel jstachowintel marked this pull request as ready for review February 20, 2025 14:54
@jstachowintel jstachowintel requested a review from a team as a code owner February 20, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant