Fix #200

onebeyond · Jun 14, 2022 · 155c57e · 155c57e
1 parent 8427ae4
commit 155c57e
Show file tree

Hide file tree

Showing 4 changed files with 3,833 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Change Log
 
+## 14.4.5
+
+- Fixed issue where a partial password could be logged in debug - See https://github.com/guidesmiths/rascal/issues/200 - thanks @matt1097
+
 ## 14.4.4
 
 - Fixed issue where channels were not returned to the pool after publishing a large messag - See https://github.com/guidesmiths/rascal/issues/199

diff --git a/lib/config/configure.js b/lib/config/configure.js
@@ -76,7 +76,7 @@ module.exports = _.curry((rascalConfig, next) => {
     connection.pathname = connection.vhost === '/' ? '' : connection.vhost;
     connection.query = connection.options;
     connection.url = connection.url || url.format(connection);
-    connection.loggableUrl = connection.url.replace(/:[^:]*?@/, ':***@');
+    connection.loggableUrl = connection.url.replace(/:[^:]*@/, ':***@');
     connection.index = getConnectionIndex(vhostConfig.connectionStrategy, connection, index);
     configureManagementConnection(vhostConfig, vhostName, connection);
   }