Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve multi-checkbox to disabled when selected option with a true disableOthers #278

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

Xexuline
Copy link
Contributor

Description

Send option on disableOthers to allow forcing the disabling of elements only when disableOthers is explicitly enabled.

Motivation and Context

This problem was detected on client project, where implementing the disableOthers functionality

How Has This Been Tested?

Tested locally importing the updated library into package.json

Screenshots (if appropriate):

Before fix
https://github.com/user-attachments/assets/50f81edb-0c6f-4dba-86e6-68418d81cef5

After fix
https://github.com/user-attachments/assets/ad720907-60c3-43a3-920c-04fbb9e994b9

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Xexuline Xexuline changed the title [FIX] | Improve multi-checkbox to disabled when selected option with disableOthers: true feat: Improve multi-checkbox to disabled when selected option with disableOthers: true Jan 24, 2025
@Xexuline Xexuline changed the title feat: Improve multi-checkbox to disabled when selected option with disableOthers: true Feat: Improve multi-checkbox to disabled when selected option with disableOthers: true Jan 24, 2025
@Xexuline Xexuline requested a review from matyasjay January 24, 2025 09:04
Copy link
Member

@matyasjay matyasjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xexuline Xexuline changed the title Feat: Improve multi-checkbox to disabled when selected option with disableOthers: true Fix: Improve multi-checkbox to disabled when selected option with disableOthers: true Jan 24, 2025
@Xexuline Xexuline changed the title Fix: Improve multi-checkbox to disabled when selected option with disableOthers: true Fix: Improve multi-checkbox to disabled when selected option with a true disableOthers Jan 24, 2025
@Xexuline Xexuline changed the title Fix: Improve multi-checkbox to disabled when selected option with a true disableOthers fix: improve multi-checkbox to disabled when selected option with a true disableOthers Jan 24, 2025
@Xexuline Xexuline merged commit 62cc1d4 into main Jan 24, 2025
8 of 11 checks passed
@Xexuline Xexuline deleted the fix/disableOthers branch January 24, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants