🐛 Multiple requests on same URL would fail #2356
Open
+36
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have multiple simultaneous requests using Kingfisher that hits the same endpoint the task management system would fail before this. Simply put, because the tasks map, uses the URL as the key it wouldn't be able to store the different requests.
However Kingfisher does seem to handle this case in
task(for task: URLSessionTask) -> SessionDataTask?
by looking at both the URL and the task id. So I changed the key of thetasks
map to include both for lookup.Before this change Kingfisher would leak the continuation it creates in
downloadImage(with:options)
in ÌmageDownloader.