Small improvements in google api client file #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit performs two main tasks: 1. Removes unused imports from the ApiClient. 2. Cleans up conditional imports. This was done for three instances where imports were unnecessarily being loaded under certain conditions. There might be more instances which can be cleaned up in the future.
Removal of unused attributes in ApiClient
Add generic type information to various methods and parameters. This change cleans up warnings (and slightly improves readability as makes intention clearer)
Instead of using the fully qualified name 'java.security.cert.X509Certificate' every time, use 'X509Certificate' directly in the code.
|
@joninvski as discussed let's close this PR since the benefit is quite small and the effort for keeping these changes in the template is important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality change.
I am adding another functionality, and while doing that, i took the opportunity to get rid of the warnings that were showing up in the generated file.