Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token Manipulation Parity Mobile #112 [sub]#903 #904 #905 #906 #915

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

zhouxl
Copy link
Collaborator

@zhouxl zhouxl commented Mar 6, 2025

Related Issue

Link #112
Closes #903 #904 #905 #906

Summary of Changes

allowed decimals = min(network decimals, coin decimals)

Restrict token transfers from Cadence to Cadence to a maximum precision of 8 decimal places.
Restrict token transfers from the EVM to Cadence to the maximum precision supported by the specific token, with a maximum of 8 decimal places.
Restrict token transfers from Cadence to the EVM to the maximum precision supported by the specific token, with a maximum of 8 decimal places.
Restrict token transfers from the EVM to the EVM to the maximum precision supported by the specific token.

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

simulator_screenshot_8AF1C91E-196A-4A31-B00E-5928B887088F
cadence to cadence
simulator_screenshot_977A999A-6B2C-4BF7-82D3-1B8160E0C89D
cadence to evm

simulator_screenshot_6B50079C-420A-4DDF-A632-F1A27359D3B2
evm to cadence

simulator_screenshot_E0816F77-11CA-410E-ACBF-E9593559510A
evm to evm

@zhouxl zhouxl requested a review from a team as a code owner March 6, 2025 05:49
@zhouxl zhouxl linked an issue Mar 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] EVM -> EVM account token transfer precision [FEATURE] Cadence -> Cadence token transfer precision
2 participants