Skip to content

Commit

Permalink
Merge pull request #3675 from onflow/fxamacker/remove-unused-function…
Browse files Browse the repository at this point in the history
…s-for-atree-typeinfo

Remove unused Identifier() function from structs implementing atree.TypeInfo
  • Loading branch information
fxamacker authored Nov 12, 2024
2 parents a56e521 + 28a1f00 commit 44376e4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
8 changes: 0 additions & 8 deletions interpreter/encode.go
Original file line number Diff line number Diff line change
Expand Up @@ -1684,10 +1684,6 @@ func (c compositeTypeInfo) IsComposite() bool {
return true
}

func (c compositeTypeInfo) Identifier() string {
return string(c.location.TypeID(nil, c.qualifiedIdentifier))
}

func (c compositeTypeInfo) Copy() atree.TypeInfo {
// Return c as is because c is a value type.
return c
Expand Down Expand Up @@ -1741,10 +1737,6 @@ func (e EmptyTypeInfo) IsComposite() bool {
return false
}

func (e EmptyTypeInfo) Identifier() string {
return ""
}

func (e EmptyTypeInfo) Copy() atree.TypeInfo {
return e
}
Expand Down
12 changes: 0 additions & 12 deletions interpreter/statictype.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,6 @@ func (t *VariableSizedStaticType) Copy() atree.TypeInfo {
return t
}

func (t *VariableSizedStaticType) Identifier() string {
return string(t.ID())
}

func (*VariableSizedStaticType) isStaticType() {}

func (*VariableSizedStaticType) elementSize() uint {
Expand Down Expand Up @@ -382,10 +378,6 @@ func (t *ConstantSizedStaticType) Copy() atree.TypeInfo {
return t
}

func (t *ConstantSizedStaticType) Identifier() string {
return string(t.ID())
}

func (*ConstantSizedStaticType) isStaticType() {}

func (*ConstantSizedStaticType) elementSize() uint {
Expand Down Expand Up @@ -464,10 +456,6 @@ func (t *DictionaryStaticType) Copy() atree.TypeInfo {
return t
}

func (t *DictionaryStaticType) Identifier() string {
return string(t.ID())
}

func (*DictionaryStaticType) isStaticType() {}

func (*DictionaryStaticType) elementSize() uint {
Expand Down

0 comments on commit 44376e4

Please sign in to comment.