Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of flow accounts create #1779

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 3, 2024

Closes #1778

Description

Fetch the account from the network instead of trying to impute details ourselves. There's currently missing values and there's really no benefit to trying to derive this without just hitting the network.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added Bug The issue represents a bug, malfunction, regression Improvement Technical work without new features, refactoring, improving tests Bugfix and removed Bug The issue represents a bug, malfunction, regression Improvement Technical work without new features, refactoring, improving tests labels Oct 3, 2024
@jribbink jribbink merged commit 594a7af into master Oct 3, 2024
11 checks passed
@jribbink jribbink deleted the jribbink/acct-create-fix branch October 3, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account creation displays wrong info
3 participants