Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align block header with protobuf schema #778

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

illia-malachyn
Copy link
Contributor

Closes: #765

test/entities.go Outdated
View: 42,
BlockID: g.ids.New(),
SignerIndices: []byte("dummy"),
SigData: []byte("dummy"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I come up with some generator for places where I can use "dummy"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, you can have it generate random data of some length. not sure what's available in this repo, but here's the implementations in flow-go
https://github.com/onflow/flow-go/blob/0dde73002b873c30a94e995f80b97ad2cc42355e/utils/unittest/fixtures.go#L1068

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added BytesGenerator to this PR

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 85.82677% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.78%. Comparing base (7b58582) to head (d070f5e).
Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 82.60% 8 Missing and 8 partials ⚠️
test/entities.go 94.28% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   52.92%   56.78%   +3.86%     
==========================================
  Files          35       35              
  Lines        5580     6098     +518     
==========================================
+ Hits         2953     3463     +510     
+ Misses       2231     2136      -95     
- Partials      396      499     +103     
Flag Coverage Δ
unittests 56.78% <85.82%> (+3.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockHeader response object is different in sdk and flow/protobuf
4 participants