-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align block header with protobuf schema #778
base: master
Are you sure you want to change the base?
align block header with protobuf schema #778
Conversation
test/entities.go
Outdated
View: 42, | ||
BlockID: g.ids.New(), | ||
SignerIndices: []byte("dummy"), | ||
SigData: []byte("dummy"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I come up with some generator for places where I can use "dummy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, you can have it generate random data of some length. not sure what's available in this repo, but here's the implementations in flow-go
https://github.com/onflow/flow-go/blob/0dde73002b873c30a94e995f80b97ad2cc42355e/utils/unittest/fixtures.go#L1068
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added BytesGenerator
to this PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 52.92% 56.78% +3.86%
==========================================
Files 35 35
Lines 5580 6098 +518
==========================================
+ Hits 2953 3463 +510
+ Misses 2231 2136 -95
- Partials 396 499 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes: #765