Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves: Multi-Model Analysis Fix and Improvement #17

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Resolves: Multi-Model Analysis Fix and Improvement #17

merged 6 commits into from
Jan 30, 2025

Conversation

pcolange
Copy link
Collaborator

closes #16

@pcolange pcolange self-assigned this Jan 29, 2025
@vgodsoe
Copy link
Collaborator

vgodsoe commented Jan 30, 2025

Validated your fixes, however, I'm still seeing an issue on the following:

  • When saving reports, if you click the cancel button in Digest, it doesn't stop the operation (i.e. the reports are still saved).

Also, recommendation would be to rev the Digest version.

vgodsoe
vgodsoe approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@vgodsoe vgodsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated and LGTM!

@pcolange pcolange merged commit f4337d8 into main Jan 30, 2025
7 checks passed
@pcolange pcolange deleted the mma/16 branch January 31, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgodsoe vgodsoe vgodsoe approved these changes

@danielholanda danielholanda Awaiting requested review from danielholanda

Assignees

@pcolange pcolange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-Model Analysis Fix and Improvement
2 participants
@pcolange @vgodsoe