This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
Fix tf.keras CI build on RNN recurrent_v2 #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
changed the title
wenbingl
approved these changes
Dec 4, 2020
|
Thanks @jiafatom! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR lacks the change on registering RNN recurrent_v2 conversion, so it causes linux-tf-keras-ci failure on py36 case here when tensorflow==1.15.0.
This PR fixes it.
I also find
test_rnn_state_passingpasses for tf 2.3 locally, so enable this test in CI build.