Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Set axes=[0] for apply_squeeze rather than leaving unset #668

Merged
merged 5 commits into from
Dec 17, 2020

Conversation

jiafatom
Copy link
Collaborator

@jiafatom jiafatom commented Dec 17, 2020

We should set axes=[0], because Squeeze op has different meaning if we don't set axes -- it squeezes out all dimensions that has shape dim 1.

@jiafatom jiafatom changed the title Set axes=[0] as default for Squeeze Set axes=[0] as default for apply_squeeze Dec 17, 2020
@jiafatom jiafatom requested a review from wenbingl December 17, 2020 04:38
@jiafatom jiafatom changed the title Set axes=[0] as default for apply_squeeze Set axes=[0] for apply_squeeze rather than leaving unset Dec 17, 2020
@jiafatom jiafatom merged commit 16a42f5 into onnx:master Dec 17, 2020
@jiafatom jiafatom deleted the squeeze_default_axes branch December 17, 2020 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants