Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse sess in backend #273

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

fumihwh
Copy link
Collaborator

@fumihwh fumihwh commented Oct 4, 2018

Copy link
Collaborator

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simply use self._sess, rather than additional sess?

@fumihwh
Copy link
Collaborator Author

fumihwh commented Oct 5, 2018

@chinhuang007 We want tf_rep.run be stateless.


:returns: A Session object.
"""
return tf.Session(self.graph)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be tf.Session(graph=self.graph)?

Copy link
Collaborator

@chinhuang007 chinhuang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anuar12
Copy link

anuar12 commented Mar 8, 2019

Is there any chance this PR gets accepted? I was actually facing the exact problem this PR is trying to fix.

# Conflicts:
#	onnx_tf/backend_rep.py
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2019

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants