Add consecutive redos test case #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipe-augusto
commented
Jun 16, 2024
| @@ -216,6 +216,10 @@ export class AutomergeRepoUndoRedo<T> { | |||
| }); | |||
|
|
|||
| if (heads) { | |||
| if (stack.redos.length > 0) { | |||
There was a problem hiding this comment.
this fixes the can apply consecutive redos on untracked text test and it does makes sense in my head I guess
| @@ -174,7 +174,7 @@ export class AutomergeRepoUndoRedo<T> { | |||
| heads, | |||
| ); | |||
|
|
|||
| change.redo.patches = unpatchAll(before, patches); | |||
| // change.redo.patches = unpatchAll(before, patches); | |||
There was a problem hiding this comment.
this one fixes the can apply redos and undos but at the same time it breaks the local undo + global redo test
|
Can you just clarify what you are hoping to test for here? Is the idea that you have 2 peers, one makes changes, then the other. You then undo twice on the first peer, and then redo twice and would expect to return to the same value? |
|
@acurrieclark yes, I think that is the expected behavior, isn't it? |
|
It is, absolutely! I was just trying to work out if the test makes changes in the way I expected. I'll take a look and let you know. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add consecutive redos test case