Skip to content

Commit

Permalink
Merge branch 'master' into release
Browse files Browse the repository at this point in the history
  • Loading branch information
James Criscuolo committed Jun 18, 2019
2 parents bf51bcb + dfb105a commit 2ba19d2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
5 changes: 3 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "sip.js",
"title": "SIP.js",
"description": "A simple, intuitive, and powerful JavaScript signaling library",
"version": "0.14.5",
"version": "0.14.6",
"license": "MIT",
"main": "./lib/index.js",
"types": "./lib/index.d.ts",
Expand All @@ -26,13 +26,13 @@
"typescript"
],
"dependencies": {
"@types/node": "^12.0.8",
"crypto-js": "^3.1.9-1",
"tslib": "^1.10.0"
},
"devDependencies": {
"@types/crypto-js": "^3.1.43",
"@types/jasmine": "^3.3.13",
"@types/node": "^12.0.8",
"circular-dependency-plugin": "^5.0.2",
"jasmine-core": "^3.4.0",
"karma": "^4.1.0",
Expand Down
4 changes: 2 additions & 2 deletions src/UA.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ export class UA extends EventEmitter {
if (this.configuration.autostop) {
// Google Chrome Packaged Apps don't allow 'unload' listeners: unload is not available in packaged apps
const googleChromePackagedApp = typeof chrome !== "undefined" && chrome.app && chrome.app.runtime ? true : false;
if (window && !googleChromePackagedApp) {
if (typeof window !== "undefined" && !googleChromePackagedApp) {
window.removeEventListener("unload", this.unloadListener);
}
}
Expand Down Expand Up @@ -590,7 +590,7 @@ export class UA extends EventEmitter {
if (this.configuration.autostop) {
// Google Chrome Packaged Apps don't allow 'unload' listeners: unload is not available in packaged apps
const googleChromePackagedApp = typeof chrome !== "undefined" && chrome.app && chrome.app.runtime ? true : false;
if (window && !googleChromePackagedApp) {
if (typeof window !== "undefined" && !googleChromePackagedApp) {
window.addEventListener("unload", this.unloadListener);
}
}
Expand Down

0 comments on commit 2ba19d2

Please sign in to comment.