Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SearchTool optional for Slack bots #3816

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 28, 2025

Make SearchTool Optional but Enabled by Default for Slack Bots

[x] Override Linear Check

Changes

  • Modified handle_regular_answer.py to respect SearchTool configuration
    • Added check for SearchTool in persona's tools
    • Changed search behavior to AS_NEEDED/DISABLED based on tool presence
  • Updated slack_channel_config.py to include SearchTool by default
    • SearchTool remains in default tool_ids for new Slack bots
    • Can be removed through UI if desired

Why

This change provides flexibility in Slack bot configuration while maintaining the default behavior. Admins can now:

  1. Keep using SearchTool (default behavior)
  2. Disable SearchTool for specific bots through the UI

Testing

  • Verified UI supports optional tool configuration
  • Confirmed backward compatibility for existing bots
  • Tested dynamic SearchTool behavior in message handling

Impact

  • Existing Slack bots: No changes (SearchTool remains enabled)
  • New Slack bots: SearchTool enabled by default but removable
  • Message handling: Respects bot's tool configuration

Link to Devin run: https://app.devin.ai/sessions/37f11c36c07441f29c2438c5736fb197

- Remove hardcoded SearchTool requirement from create_slack_channel_persona
- Keep SearchTool existence check for system integrity
- Maintain backward compatibility for existing Slack bot personas
- Allow SearchTool to be enabled/disabled via UI as needed

This change allows Slack bots to be created without SearchTool by default,
while preserving the ability to enable it through the UI if desired.

Co-Authored-By: Chris Weaver <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:09pm

devin-ai-integration bot and others added 2 commits January 29, 2025 17:49
- Modified handle_regular_answer.py to respect SearchTool configuration
- Updated slack_channel_config.py to include SearchTool by default
- Maintains backward compatibility for existing Slack bots

The changes allow Slack bots to function without SearchTool while keeping it enabled by default for new bots. This provides more flexibility in bot configuration while maintaining existing behavior as the default.

Co-Authored-By: Chris Weaver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants