Add option to not re-index #4157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
Mar 2, 2025
| secondary_index_building=len(search_settings_list) > 1, | ||
| db_session=db_session, | ||
| ): | ||
| continue | ||
|
|
||
| reindex = False | ||
| if search_settings_instance.id == search_settings_list[0].id: | ||
| if search_settings_instance.status == IndexModelStatus.PRESENT: |
There was a problem hiding this comment.
@rkuo-danswer any specific reason we did it based on ordering rather than checking the status?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/danswer/issue/DAN-1492/add-options-to-address-vespa-memory-issues-at-scale
Allows for:
This is hidden for multi-tenant for now, as we should probably just provide a default / not expose this.
Also includes some misc modal cleanup (standardizing button layout in the bottom right) + label standardization.
How Has This Been Tested?
Tested all locally (switching between all different options).
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.