Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed, improved, and unified Docker environment #5474

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Fixed, improved, and unified Docker environment #5474

wants to merge 8 commits into from

Commits on Feb 9, 2024

  1. Unified Dockerfile 

    - Moved GPU_CHOICE from RUN to ARG instruction so all the Dockerfiles could be unified into a single Dockerfile
- Added CLI_ARGS to start_linux.sh command (very important fix, without it CLI_ARGS are ignored)
- Set HOME as global instead of process-specific envvar (so it's also set when entering the container manually)
- Removed redundant WORKDIR (we've already changed into it)
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    9276b42 View commit details
    Browse the repository at this point in the history

  2. Update .env.example 

    Added PYTORCH_KERNEL_CACHE_PATH pointing at cache dir to fix "UserWarning: Specified kernel cache directory could not be created! This disables kernel caching."
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    94cc0fc View commit details
    Browse the repository at this point in the history

  3. Update .env.example 

    Removed trailing slashes from cache paths for consistency
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    84a5287 View commit details
    Browse the repository at this point in the history

  4. Delete docker/*/Dockerfile

    Stefan Schwarz committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0a07172 View commit details
    Browse the repository at this point in the history

  5. Update docker-compose.yml for unified Dockerfile

    Stefan Schwarz committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2034dc7 View commit details
    Browse the repository at this point in the history

  6. Update 09 - Docker.md 

    Create symlinks and missing dirs
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f42023b View commit details
    Browse the repository at this point in the history

  7. Update .env.example 

    Added APP_RUNTIME_UID to APP_RUNTIME_GID (so you can not only define the group, but also the user for access to mounted volumes)
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ea65c64 View commit details
    Browse the repository at this point in the history

  8. Update .gitignore 

    Added .dockerignore to .gitignore
    @WolframRavenwolf
    WolframRavenwolf authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    47a8d8b View commit details
    Browse the repository at this point in the history