Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme column #890

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Add theme column #890

merged 7 commits into from
Oct 11, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Oct 11, 2024 •
edited
Loading

Features:

  • Add support for filtering by theme, domains, country_codes and asns
  • Add support for setting slug of finding
  • Add support for retrieving findings by slug

Changed:

  • It's now possible to create a finding with the published flag set on creation

Fixes:

  • Fix bug in end_time not being returned
  • Fix creation to behave like old explorer

Closes:

@hellais
Add theme column
11d2efa 
* Add support for filtering by theme, country_code and asns
* Add support for setting slug of finding
* Add support for retrieving findings by slug
@hellais
Add support for filter by domain
ca149a0
@hellais
Fix type of downgrade
92ecab5
@hellais
Fix tests and add more tests related to filtering
1887f36
@hellais
Remove dead code and reach 100% coverage
ab4289d
DecFox
DecFox approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellais hellais merged commit 13806de into master Oct 11, 2024
6 of 7 checks passed
@hellais hellais deleted the findings-filter branch October 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecFox DecFox DecFox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellais @DecFox