Fix bug in availability zone mapping #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a bug in the netblock arithmetics for allocating the private vs the public subnets based on availability zones. Due to this bug we had instances being deployed into private networks which had an availability zone that wasn't in our list of supported zones and therefore we were never deploying tasks onto it.
In order to address this, since it requires changing the networking stack, we had to also implement a lot of changes to how security groups are being created and switched, which was anyways a good things to do.
The key point is that when you would like to modify a security group, because for example you need to change it's subnet, you need to create the new security group before deleting the old one.
In order to do this, you need to make use of
name_prefixinstead of staticnameattributes.This PR does that.