Skip to content

Commit

Permalink
[backport] doc(webconnectivity): mention DNS improvements
Browse files Browse the repository at this point in the history
This diff backports ad952ac.

See ooni/probe#2029 (comment)
  • Loading branch information
bassosimone committed Mar 16, 2023
1 parent 0f9b235 commit 242f0c2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions internal/experiment/webconnectivitylte/analysisdns.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ func (tk *TestKeys) analysisDNSUnexpectedFailure(logger model.Logger) {
logger.Warnf("DNS: unexpected failure %s in #%d", *query.Failure, query.TransactionID)
tk.DNSFlags |= AnalysisDNSUnexpectedFailure
// continue processing so we print all the unexpected failures

// TODO(https://github.com/ooni/probe/issues/2029#issuecomment-1411716295): we need
// to ensure we correctly handle the android_dns_cache_no_data case.
}
}

Expand Down

0 comments on commit 242f0c2

Please sign in to comment.