Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: app crashes when disabling all categories #526

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

aanorbel
Copy link
Member

Fixes ooni/probe#2513

Proposed Changes

  • Disables WebsitesSuite if no category is enabled.
  • Prevent checkIn call if no category is enabled.

@bassosimone bassosimone changed the title Fix: app crashes when disabling all categories fix: app crashes when disabling all categories Jul 26, 2023
ooniprobe/Utility/OONIApi.m Outdated Show resolved Hide resolved
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐳

@aanorbel aanorbel changed the title fix: app crashes when disabling all categories Fix: app crashes when disabling all categories Jul 31, 2023
@aanorbel aanorbel merged commit 2b8c12a into master Jul 31, 2023
4 checks passed
@aanorbel aanorbel deleted the issues/2513 branch July 31, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ios: app crashes when disabling all categories
3 participants