fix: invalid handling of OONI Run v1 link with partial URL #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t allows a better validation
bassosimone
suggested changes
Jul 28, 2023
There was a problem hiding this comment.
Please, write tests covering each of the possible error conditions. You can use https://www.onlinegdb.com/V81JCf11o to get some inspiration about possible test cases.
bassosimone
changed the title
Co-authored-by: Simone Basso <[email protected]>
hellais
reviewed
Jul 31, 2023
hellais
reviewed
Jul 31, 2023
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ooni/probe#2515
Proposed Changes
OoniRunViewController#validateLinkto use updated code that allows a better validation.